Re: [PATCH v3 1/4] net: airoha: Fix an error handling path in airoha_alloc_gdm_port()

[Simon Horman]

On Thu, May 15, 2025 at 11:16:56PM +0200, Lorenzo Bianconi wrote:
> > If register_netdev() fails, the error handling path of the probe will not
> > free the memory allocated by the previous airoha_metadata_dst_alloc() call
> > because port->dev->reg_state will not be NETREG_REGISTERED.
> > 
> > So, an explicit airoha_metadata_dst_free() call is needed in this case to
> > avoid a memory leak.
> > 
> > Fixes: af3cf757d5c9 ("net: airoha: Move DSA tag in DMA descriptor")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> 
> Acked-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>