Re: [PATCH v2] arm64: mm: Drop redundant check in pmd_trans_huge()
From: Will Deacon
Date: Fri May 16 2025 - 11:38:32 EST
On Thu, 08 May 2025 18:52:51 +1000, Gavin Shan wrote:
> pmd_val(pmd) is redundant because a positive pmd_present(pmd) ensures
> a positive pmd_val(pmd) according to their definitions like below.
>
> #define pmd_val(x) ((x).pmd)
> #define pmd_present(pmd) pte_present(pmd_pte(pmd))
> #define pte_present(pte) (pte_valid(pte) || pte_present_invalid(pte))
> #define pte_valid(pte) (!!(pte_val(pte) & PTE_VALID))
> #define pte_present_invalid(pte) \
> ((pte_val(pte) & (PTE_VALID | PTE_PRESENT_INVALID)) == PTE_PRESENT_INVALID)
>
> [...]
Applied to arm64 (for-next/mm), thanks!
[1/1] arm64: mm: Drop redundant check in pmd_trans_huge()
https://git.kernel.org/arm64/c/13c63ce35883
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev