Re: [PATCH] firmware: arm_scmi: Use dev_err_probe() simplify the code

[Christophe JAILLET]

Le 15/05/2025 à 14:38, long.yunjian@xxxxxxxxxx a écrit :
> From: Yumeng Fang <fang.yumeng@xxxxxxxxxx>
>
> In the probe path, dev_err() can be replaced with dev_err_probe()
> which will check if error code is -EPROBE_DEFER and prints the
> error name. It also sets the defer probe reason which can be
> checked later through debugfs.
>
> Signed-off-by: Yumeng Fang <fang.yumeng@xxxxxxxxxx>
> ---
>   drivers/firmware/arm_scmi/transports/mailbox.c | 17 +++++++----------
>   1 file changed, 7 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/transports/mailbox.c b/drivers/firmware/arm_scmi/transports/mailbox.c
> index bd041c99b92b..816e79537935 100644
> --- a/drivers/firmware/arm_scmi/transports/mailbox.c
> +++ b/drivers/firmware/arm_scmi/transports/mailbox.c
> @@ -13,6 +13,7 @@
>   #include <linux/of_address.h>
>   #include <linux/platform_device.h>
>   #include <linux/slab.h>
> +#include <linux/dev_printk.h>

includes are (mostly) alphabetically ordered right-now.
So, It would be better to keep this logic, IMHO.

CJ