Re: [PATCH] scsi: ufs: mcq: delete ufshcd_release_scsi_cmd in ufshcd_mcq_abort

From: Bart Van Assche
Date: Fri May 16 2025 - 10:20:25 EST


On 5/16/25 1:38 AM, ping.gao wrote:
after ufs UFS_ABORT_TASK process successfully , host will generate
mcq irq for abort tag with response OCS_ABORTED
ufshcd_compl_one_cqe ->
ufshcd_release_scsi_cmd

But in ufshcd_mcq_abort already do ufshcd_release_scsi_cmd, this means
__ufshcd_release will be done twice.

This means hba->clk_gating.active_reqs also will be decrease twice, it
will be negtive, so delete ufshcd_release_scsi_cmd in ufshcd_mcq_abort
function.

static void __ufshcd_release(struct ufs_hba *hba)
{
if (!ufshcd_is_clkgating_allowed(hba))
return;

hba->clk_gating.active_reqs--;

if (hba->clk_gating.active_reqs < 0) {
panic("ufs abnormal active_reqs!!!!!!");
}

...
}
Signed-off-by: ping.gao <ping.gao@xxxxxxxxxxx>
A blank line is required between a patch description and a Signed-off-by tag. Additionally, please add a Fixes: tag to the patch description.

Thanks,

Bart.