Re: [PATCH v2 1/3] dt-bindings: i2c: Add required properties

[Jon Hunter]

On 16/05/2025 13:53, Krzysztof Kozlowski wrote:
> On 16/05/2025 14:43, Akhil R wrote:
> > Add required DT properties for Tegra I2C controllers.
>
> Why? Required by whom/what? Some context or any justification is needed
> here. Are you breaking the ABI (means: prove that you are not).
>
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
>
> > Signed-off-by: Akhil R <akhilrajeev@xxxxxxxxxx>
> > ---
> > v1->v2:
> >    * Added all required properties
> >
> >   .../bindings/i2c/nvidia,tegra20-i2c.yaml      | 19 +++++++++++++++++++
> >   1 file changed, 19 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > index 19aefc022c8b..0717f2304cfc 100644
> > --- a/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/nvidia,tegra20-i2c.yaml
> > @@ -118,6 +118,13 @@ properties:
> >         - const: rx
> >         - const: tx
> >   
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - clocks
> > +  - clock-names
> > +
> >   allOf:
> >     - $ref: /schemas/i2c/i2c-controller.yaml
> >     - if:
> > @@ -171,6 +178,18 @@ allOf:
> >         properties:
> >           power-domains: false
> >   
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum:
> > +                - nvidia,tegra194-i2c
> > +    then:
> > +        required:
>
> Never tested, so quite dissapointing.
>
> Test your patches before sending, not after.

ACK. Clearly we need to do a better job here. It is noted.

Thanks
Jon

--
nvpublic