Re: [PATCH v1 1/2] ethernet: eswin: Document for eic7700 SoC

[Krzysztof Kozlowski]

On 16/05/2025 03:10, weishangjuan@xxxxxxxxxxxxxxxxxx wrote:
> From: Shangjuan Wei <weishangjuan@xxxxxxxxxxxxxxxxxx>
> 
> Add ESWIN EIC7700 Ethernet controller, supporting
> multi-rate (10M/100M/1G) auto-negotiation, PHY LED configuration,
> clock/reset control, and AXI bus parameter optimization.
> 
> Signed-off-by: Zhi Li <lizhi2@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: Shangjuan Wei <weishangjuan@xxxxxxxxxxxxxxxxxx>

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters


> ---
>  .../bindings/net/eswin,eic7700-eth.yaml       | 142 ++++++++++++++++++
>  1 file changed, 142 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> 
> diff --git a/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> new file mode 100644
> index 000000000000..6cb9c109c036
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/eswin,eic7700-eth.yaml
> @@ -0,0 +1,142 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/eswin,eic7700-eth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Eswin EIC7700 SOC Eth Controller
> +
> +maintainers:
> +  - Shuang Liang <liangshuang@xxxxxxxxxxxxxxxxxx>
> +  - Zhi Li <lizhi2@xxxxxxxxxxxxxxxxxx>
> +  - Shangjuan Wei <weishangjuan@xxxxxxxxxxxxxxxxxx>
> +
> +description: |

Same comments apply as for all of your patches.

> +  The eth controller registers are part of the syscrg block on
> +  the EIC7700 SoC.
> +
> +properties:
> +  compatible:
> +    const: eswin,eic7700-qos-eth
> +
> +  reg:
> +    minItems: 1
> +    items:
> +      - description: Base address and size
> +      - description: Extension region (optional)

How it can be optional? This is SoC. It is strictly defined, isn't it?

> +
> +  interrupt-names:
> +    const: macirq
> +
> +  interrupts:
> +    maxItems: 1
> +
> +  phy-mode:
> +    $ref: /schemas/types.yaml#/definitions/string
> +    enum: [mii, gmii, rgmii, rmii, sgmii]
> +
> +  id:
> +    $ref: /schemas/types.yaml#/definitions/uint32
> +    description: Controller instance ID

No, drop. IDs are not allowed.

> +
> +  clocks:
> +    minItems: 3
> +    maxItems: 7

No.

I am supposed to repeat the same comments... So no.

All my comments apply to all eswin patches. For driver, bindings,
everything. I suggest to slow down and learn from one review.

I finish review here.

Best regards,
Krzysztof