Re: [PATCH v2 2/8] dt-bindings: media: nxp: Add Wave6 video codec device
From: Krzysztof Kozlowski
Date: Fri May 16 2025 - 08:56:12 EST
On 13/05/2025 09:39, Nas Chung wrote:
>>
>> All of above are wrong for the SoC...
>>
>>>
>>> #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> #include <dt-bindings/clock/nxp,imx95-clock.h>
>>>
>>> soc {
>>> #address-cells = <2>;
>>> #size-cells = <2>;
>>>
>>> vpu: video-codec {
>>> compatible = "nxp,imx95-vpu", "cnm,wave633c";
>>
>> What does this device represent? It is not "ctrl", because you made ctrl
>> separate device node. Your binding description suggests that is the VPU
>> control region.
>
> My intention was to represent the MMIO VPU device, which includes
> both the core and control nodes.
Then what is the VPU device if not CTRL? What is the CTRL device?
Best regards,
Krzysztof