Re: [PATCH] arm64: dts: qcom: sm8550: Add support for camss

[Wenmeng Liu]

On 2025/5/1 9:15, Bryan O'Donoghue wrote:
> On 30/04/2025 12:11, Konrad Dybcio wrote:
> > On 4/15/25 9:38 AM, Wenmeng Liu wrote:
> > > Add support for the camera subsystem on the SM8550 Qualcomm SoC. This
> > > includes bringing up the CSIPHY, CSID, VFE/RDI interfaces.
> > >
> > > SM8550 provides
> > > - 3 x VFE, 3 RDI per VFE
> > > - 2 x VFE Lite, 4 RDI per VFE
> > > - 3 x CSID
> > > - 2 x CSID Lite
> > > - 8 x CSI PHY
> > >
> > > Co-developed-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> > > Signed-off-by: Depeng Shao <quic_depengs@xxxxxxxxxxx>
> > > Signed-off-by: Wenmeng Liu <quic_wenmliu@xxxxxxxxxxx>
> > > ---
> >
> > [...]
> >
> > > +                     <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
> > > +                     <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
> >
> > It *may* be 689 instead but I'm not 100% sure
> >
> > Otherwise the numbers look good
> >
> > Bryan, Vlad, please also take a look
> >
> > Konrad
>
> +                     <GIC_SPI 688 IRQ_TYPE_EDGE_RISING>,
> This should be 689 yes
>
> ---
> bod

Hi Bryan,Konrad,

I confirmed that the value is 688 instead of 689. The documentation 
incorrectly listed it as 689. To CC linux-media, I have resent the patch:
https://lore.kernel.org/linux-arm-msm/20250516072707.388332-1-quic_wenmliu@xxxxxxxxxxx/

Thanks,
wenmeng