Re: [PATCH v5 07/10] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC

[Sven Peter]

Hi Stefan,

On Sun, May 11, 2025, at 12:07, Stefan Wahren wrote:
> Hi Sven,
>
> Am 11.05.25 um 10:18 schrieb Sven Peter via B4 Relay:

[...]

>> +/* Helpers to read/write a u8 given a struct nvmem_cell */
>> +static int nvmem_cell_get_u8(struct nvmem_cell *cell)
>> +{
>> +	size_t len;
>> +	u8 val;
>> +	void *ret = nvmem_cell_read(cell, &len);
> in case this series needs a respin, please rename the pointer (e.g. 
> buf). This is very unusual, because ret is usually of type int.

That's indeed odd, I'll rename it.


Thanks,


Sven