Re: [v3 PATCH] crypto: marvell/cesa - Do not chain submitted requests

From: Herbert Xu
Date: Fri May 09 2025 - 21:38:13 EST


On Sat, May 10, 2025 at 09:15:50AM +0800, Herbert Xu wrote:
>
> I see some bugs in the driver with regards to zero-length updates,
> but I'm at a loss as to why that would only make a difference when
> run concurrently.

In particular, when testmgr does an update+final, it will give a
non-NULL SG list to the final call.

The buggy code in marvell/cesa will then read that non-NULL SG list
during the final call and overwrite the cached bytes with it.
However, I still can't see why that would make a difference because
it should contain the same data.

Cheers,
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt