Re: [GIT PULL] TEE updates for 6.16

From: Jann Horn
Date: Fri May 09 2025 - 17:23:08 EST


On Fri, May 9, 2025 at 11:14 PM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Fri, May 9, 2025, at 08:51, Jens Wiklander wrote:
> > ----------------------------------------------------------------
> > Small TEE updates for v6.16
> >
> > - Remove an unnecessary NULL check before release_firmware() in the
> > OP-TEE driver
> > - Prevent a size wrap in the TEE subsystem. The wrap would have been caught
> > later in the code so no security consequences.
> >
> > ----------------------------------------------------------------
> > Chen Ni (1):
> > tee: optee: smc: remove unnecessary NULL check before release_firmware()
> >
> > Jann Horn (1):
> > tee: Prevent size calculation wraparound on 32-bit kernels
> >
>
> The second patch looks like it should be a bugfix for 6.15 instead,
> any reason to have it only in 6.16?

FWIW, it's more of a cleanup than a real bugfix; there is an unsigned
integer wraparound, but if that occurs, we're guaranteed to hit a
memory allocation bailout pretty much immediately afterwards. So I
think putting it in 6.16 is reasonable.