Re: (subset) [PATCH v4 0/4] X1E Asus Zenbook A14 support
From: Bjorn Andersson
Date: Fri May 09 2025 - 13:09:02 EST
On Wed, May 07, 2025 at 06:36:12PM +0200, Aleksandrs Vinarskis wrote:
> On Wed, 7 May 2025 at 07:18, Bjorn Andersson <andersson@xxxxxxxxxx> wrote:
> >
> >
> > On Sat, 26 Apr 2025 14:57:56 +0200, Aleksandrs Vinarskis wrote:
> > > Introduce support for the mentioned laptop.
> > >
> > > Particular device exists in two model numbers:
> > > * UX3407QA: X1P-42-100 or X1-26-100 (as tested)
> > > * UX3407RA: X1E-78-100
> > >
> > > Mostly similar to other X1-based laptops. Notable differences are:
> > > * Wifi/Bluetooth combo being Qualcomm FastConnect 6900 on UX3407QA
> > > and Qualcomm FastConnect 7800 on UX3407RA
> > > * USB Type-C retimers are Parade PS8833, appear to behave identical
> > > to Parade PS8830
> > > * gpio90 is TZ protected
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [2/4] dt-bindings: arm: qcom: Add Asus Zenbook A14
> > commit: 9f2ae52acd5e6c95ddc55d1cc67f44860940a21b
>
>
> Thanks!
>
> I saw 2/4, 3/4 were applied. Is there a reason 4/4 was left behind,
> eg. Does it have to go through different trees like 1/4?
The reason is that patch 1 still hasn't been merged, so patch 4 fails
dtbs_check at the moment.
> I also saw that another later series with dtb changes for x1e devices
> [1] has landed, so 4/4 of the current series won't apply anymore...
> Would you like me to rebase & respin?
>
Please resubmit patch 1 alone, so that it's convenient for USB
maintainers to pick it up.
Then once this binding change is in linux-next I can pick up patch 4.
Yes it would be convenient for me if you rebase it on top of [1].
Regards,
Bjorn
> Regards,
> Alex
>
> [1] https://lore.kernel.org/all/174659597008.7675.2301017495937908497.b4-ty@xxxxxxxxxx/
> >
> > Best regards,
> > --
> > Bjorn Andersson <andersson@xxxxxxxxxx>