Re: [PATCH net-next V9 1/5] devlink: Extend devlink rate API with traffic classes bandwidth management
From: Jakub Kicinski
Date: Fri May 09 2025 - 11:16:48 EST
On Fri, 9 May 2025 08:43:05 +0300 Tariq Toukan wrote:
> + -
> + name: devlink-rate-tc-index-max
> + header: uapi/linux/devlink.h
> + type: const
> + value: 7
Ugh, still wrong, the user space headers don't have uAPI in the path
when installed. They go to /usr/include/linux/$name.h
But for defines "local" to the family you don't have to specify header:
at all, just drop it.
And please do build tests the next version:
make -C tools/net/ynl/ W=1 -j
I'm going to also give you a hint that my next complaint will be that
there are no selftests in this series, and it extends uAPI.
--
pw-bot: cr