Re: [PATCH v2 6/9] dt-bindings: cache: ax45mp-cache: allow variable cache-sets for Andes L2 cache

[Conor Dooley]

On Tue, May 06, 2025 at 05:23:21PM +0100, Conor Dooley wrote:
> On Sat, May 03, 2025 at 11:18:26PM +0800, Ben Zong-You Xie wrote:
> > The current device tree binding for the Andes AX45MP L2 cache enforces
> > a fixed number of cache-sets (1024). However, there are 2048 cache-sets in
> > the QiLai SoC. This change allows both 1024 and 2048 as valid values for
> > "cache-sets".
> > 
> > Signed-off-by: Ben Zong-You Xie <ben717@xxxxxxxxxxxxx>
> > Acked-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> 
> Applied, thanks.

You know what, I am starting to have second thoughts here. Why does the
qilai not have a specific compatible like the plic etc? I think you
should have one, and only allow the 2048 cache-sets there. I'm going to
go and drop this patch, and please do that for the next version.

Prabhakar, should we add a specific one for the rz/five too?

Attachment: signature.asc
Description: PGP signature