Re: [PATCH RFT 03/14] drm/msm/adreno: Offset the HBB value by 13

From: Konrad Dybcio
Date: Fri May 09 2025 - 08:30:41 EST


On 5/8/25 9:03 PM, Connor Abbott wrote:
> On Thu, May 8, 2025 at 2:13 PM Konrad Dybcio <konradybcio@xxxxxxxxxx> wrote:
>>
>> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> The value the UBWC hardware expects is 13 less than the actual value.
>> To make it easier to migrate to a common UBWC configuration table,
>> defer that logic to the data source (which is currently a number of
>> if-else statements with assignments in case of this driver).
>
> Don't break the value exposed to userspace!

Bah, I keep forgetting it's there.. I think I'll alter the mdss code to
do a -13 in there instead to make it a little saner with the future
getters that return the x+13 value too.

Konrad