Re: [PATCH V4 11/11] scsi: ufs: qcom: Prevent calling phy_exit before phy_init

[Nitin Rawat]

On 5/9/2025 5:08 PM, Konrad Dybcio wrote:
> On 5/3/25 6:24 PM, Nitin Rawat wrote:
> > Prevent calling phy_exit before phy_init to avoid abnormal power
> > count and the following warning during boot up.
> >
> > [5.146763] phy phy-1d80000.phy.0: phy_power_on was called before phy_init
> >
> > Fixes: 7bac65687510 ("scsi: ufs: qcom: Power off the PHY if it was already powered on in ufs_qcom_power_up_sequence()")
> > Signed-off-by: Nitin Rawat <quic_nitirawa@xxxxxxxxxxx>
> > ---
> >   drivers/ufs/host/ufs-qcom.c | 1 -
> >   1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
> > index a7e9e06847f8..db51e1e7d836 100644
> > --- a/drivers/ufs/host/ufs-qcom.c
> > +++ b/drivers/ufs/host/ufs-qcom.c
> > @@ -482,7 +482,6 @@ static int ufs_qcom_power_up_sequence(struct ufs_hba *hba)
> >
> >   	if (phy->power_count) {
> >   		ufs_qcom_phy_power_off(hba);
> > -		phy_exit(phy);
> >   	}
>
> You can also remove the {} now
Sure will review while posting next patchset.
> since this is a fix for existing issues, which I don't think has any dependencies
> on your other changes, please post it as the first patch so that the maintainer
> can pick it up more easily
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Konrad