Re: [PATCH 12/14] dt-bindings: spi: dspi: Add S32G support

[James Clark]

On 09/05/2025 12:14 pm, Krzysztof Kozlowski wrote:
> On 09/05/2025 13:05, James Clark wrote:
> > From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxx>
> >
> > Document S32G compatible strings. 's32g2' and 's32g3' use the same
> > driver so 's32g2' must follow 's32g3'.
> >
> > The SPI controller node in dts can define both host and target pinctrl.
> > The selection between them will be done based on pinctrl-names. The
> > default pinctrl will be loaded first and will be used by the host. If
> > the controller is configured as target (spi-slave property is added in
> > the dts node), the driver will look for the "slave" pinctrl and apply it
> > if found.
>
>
> I do not see any changes in the binding related to above paragraph, so I
> do not understand why are you explaining driver?

Yes it's probably a bit verbose, it's just a standard SPI binding that 
also supports target mode. I can reduce it.

I'm also not even sure the "slave" pinctrl part is correct as I was 
testing it in target mode without any special naming. I will double 
check that too.

> > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxx>
> > Signed-off-by: Larisa Grigore <larisa.grigore@xxxxxxx>
> > Signed-off-by: James Clark <james.clark@xxxxxxxxxx>
> > ---
> >   Documentation/devicetree/bindings/spi/fsl,dspi.yaml | 18 ++++++++++++++++++
> >   1 file changed, 18 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
> > index 7ca8fceda717..b5fac0bb142a 100644
> > --- a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml
> > @@ -23,6 +23,7 @@ properties:
> >             - fsl,ls2080a-dspi
> >             - fsl,ls2085a-dspi
> >             - fsl,lx2160a-dspi
> > +          - nxp,s32g2-dspi
> >         - items:
> >             - enum:
> >                 - fsl,ls1012a-dspi
> > @@ -37,6 +38,9 @@ properties:
> >         - items:
> >             - const: fsl,lx2160a-dspi
> >             - const: fsl,ls2085a-dspi
> > +      - items:
> > +          - const: nxp,s32g3-dspi
> > +          - const: nxp,s32g2-dspi
> >   
> >     reg:
> >       maxItems: 1
> > @@ -114,3 +118,17 @@ examples:
> >                   spi-cs-hold-delay-ns = <50>;
> >           };
> >       };
> > +  # S32G3 in target mode
> > +  - |
> > +    spi0: spi@401d4000 {
>
> Drop unused label.

Will do.

> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>
> Best regards,
> Krzysztof

Thanks for the review.

James