Re: [PATCH v2 2/2] dt-bindings: display: rockchip: Convert cdn-dp-rockchip.txt to yaml

[Chaoyi Chen]

Hi Krzysztof,

On 2025/5/9 17:21, Krzysztof Kozlowski wrote:
> On 09/05/2025 09:34, Chaoyi Chen wrote:
> > Hi Krzysztof,
> >
> > On 2025/5/9 15:11, Krzysztof Kozlowski wrote:
> > > On 09/05/2025 09:02, Chaoyi Chen wrote:
> > > > +
> > > > +  clock-names:
> > > > +    items:
> > > > +      - const: core-clk
> > > > +      - const: pclk
> > > > +      - const: spdif
> > > > +      - const: grf
> > > > +
> > > > +  extcon:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > +    description:
> > > > +      Phandle to the extcon device providing the cable state for the DP PHY.
> > > > +
> > > > +  interrupts:
> > > > +    maxItems: 1
> > > > +
> > > > +  phys:
> > > > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > > Just phandle. If this is an array (but why?), you need maxItems for
> > > outer and inner dimensions.
> Uh, sorry, that was supposed to be under extcon.

Oh, this also applies to extcon. Each extcon is used to indicate the 
status of the PHY.


> > I think it could be phandle or phandle-array. Since the RK3399 DP has
> Here it is obviously not needed, that's a dtschema type.

Do you mean that there is no need to explicitly specify something like 
"$ref: /schemas/types.yaml#/definitions/phandle" ?



> > two PHYs, if we put in two PHYs here, the driver will pick one PHY port
> > that is already plugged into the DP for output. If we fill in only one
> > PHY here, then output is only allowed on the corresponding PHY.
> >
> > Will add restrictions and add more descriptions in v3.
> >
> >
> > > > +    description:
> > > > +      Phandle to the PHY device for DP output.
> You need to list the items with description iinstead.

Okay, will fix in v3.


> Best regards,
> Krzysztof