Re: [PATCH v2 0/2] Optimize mremap() for large folios

From: David Hildenbrand
Date: Fri May 09 2025 - 05:30:21 EST


On 09.05.25 10:44, Lorenzo Stoakes wrote:
On Fri, May 09, 2025 at 10:57:05AM +0530, Dev Jain wrote:


On 09/05/25 12:05 am, Lorenzo Stoakes wrote:
Dev - a general comment here - but let's slow things down a little please
:)

The mprotect() version of this is still outstanding fixes and likely will
need quite a bit of checking before we can ensure it's stabilised.

And now we have this mremap() series as well which also has had quite a few
quite significant issues that have needed addressing.

So can we try to focus on one at a time, and really try to nail down the
series before moving on to the next?

We also have outstanding review on the v1, which has now been split, which
does happen sometimes but perhaps suggests that it'd work better if you
waited a couple days or such to ensure things are settled before sending a
new version when there's quite a bit of feedback?

Sure, I should have waited my bad, I usually do, this time I was in a haste
with both series for no reason :( thanks for your detailed replies btw!

No problem, I've done this in the past myself haha (sometimes even faster
than you did :P), just a case of tweaking things to fit the mm process :)

We've all been there, desperately wanting to flush the todo list ... :)

--
Cheers,

David / dhildenb