Re: [PATCH] drm/cirrus: Use non-hybrid PCI devres API
From: Philipp Stanner
Date: Fri May 09 2025 - 04:37:13 EST
On Thu, 2025-05-08 at 12:44 +0200, Javier Martinez Canillas wrote:
> Philipp Stanner <phasta@xxxxxxxxxxx> writes:
>
> Hello Philipp,
>
> > On Tue, 2025-04-22 at 23:51 +0200, Javier Martinez Canillas wrote:
> > > Philipp Stanner <phasta@xxxxxxxxxx> writes:
> > >
> > > Hello Philipp,
> > >
> > > > cirrus enables its PCI device with pcim_enable_device(). This,
> > > > implicitly, switches the function pci_request_regions() into
> > > > managed
> > > > mode, where it becomes a devres function.
> > > >
> > > > The PCI subsystem wants to remove this hybrid nature from its
> > > > interfaces. To do so, users of the aforementioned combination
> > > > of
> > > > functions must be ported to non-hybrid functions.
> > > >
> > > > Replace the call to sometimes-managed pci_request_regions()
> > > > with
> > > > one to
> > > > the always-managed pcim_request_all_regions().
> > > >
> > > > Signed-off-by: Philipp Stanner <phasta@xxxxxxxxxx>
> > > > ---
> > >
> > > Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> > >
> >
> > Who's in charge of applying this? Any objections with me just
> > putting
> > it into drm-misc-next?
> >
>
> Sure, go ahead.
Applied, thx
>
> > P.
> >
>