[PATCH v3 1/3] scsi: ufs: qcom: Check gear against max gear in vop freq_to_gear()

From: Ziqi Chen
Date: Fri May 09 2025 - 03:55:06 EST


The vop freq_to_gear() may return a gear greater than the negotiated max
gear, return the negotiated max gear if the mapped gear is greater than it.

Fixes: c02fe9e222d1 ("scsi: ufs: qcom: Implement the freq_to_gear_speed() vop")
Signed-off-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>

---
v1 -> v2:
1. Instead of return 'gear', return '0' directly if didn't find mapped
gear
2. Derectly return min_t(gear,max_gear) instead assign to 'gear' then
return it.

v2 -> v3:
Replace hard code '0' with enum 'UFS_HS_DONT_CHANGE'.
---
drivers/ufs/host/ufs-qcom.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
index 790da25cbaf3..654d970b6dec 100644
--- a/drivers/ufs/host/ufs-qcom.c
+++ b/drivers/ufs/host/ufs-qcom.c
@@ -2083,7 +2083,7 @@ static int ufs_qcom_config_esi(struct ufs_hba *hba)

static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
{
- u32 gear = 0;
+ u32 gear = UFS_HS_DONT_CHANGE;

switch (freq) {
case 403000000:
@@ -2105,10 +2105,10 @@ static u32 ufs_qcom_freq_to_gear_speed(struct ufs_hba *hba, unsigned long freq)
break;
default:
dev_err(hba->dev, "%s: Unsupported clock freq : %lu\n", __func__, freq);
- break;
+ return UFS_HS_DONT_CHANGE;
}

- return gear;
+ return min_t(u32, gear, hba->max_pwr_info.info.gear_rx);
}

/*
--
2.34.1