Re: [PATCH v6 5/8] selftests: ublk: kublk: lift queue initialization out of thread
From: Ming Lei
Date: Fri May 09 2025 - 03:44:50 EST
On Wed, May 07, 2025 at 03:49:39PM -0600, Uday Shankar wrote:
> Currently, each ublk server I/O handler thread initializes its own
> queue. However, as we move towards decoupled ublk_queues and ublk server
> threads, this model does not make sense anymore, as there will no longer
> be a concept of a thread having "its own" queue. So lift queue
> initialization out of the per-thread ublk_io_handler_fn and into a loop
> in ublk_start_daemon (which runs once for each device).
>
> There is a part of ublk_queue_init (ring initialization) which does
> actually need to happen on the thread that will use the ring; that is
> separated into a separate ublk_thread_init which is still called by each
> I/O handler thread.
>
> Signed-off-by: Uday Shankar <ushankar@xxxxxxxxxxxxxxx>
Reviewed-by: Ming Lei <ming.lei@xxxxxxxxxx>
thanks,
Ming