Re: [PATCH v1] selftests/mm: add simple VM_PFNMAP tests based on mmap'ing /dev/mem

[David Hildenbrand]

On 09.05.25 07:35, Dev Jain wrote:
> On 09/05/25 3:50 am, David Hildenbrand wrote:
> > Let's test some basic functionality using /dev/mem. These tests will
> > implicitly cover some PAT (Page Attribute Handling) handling on x86.
> >
> > These tests will only run when /dev/mem access to the first two pages
> > in physical address space is possible and allowed; otherwise, the tests
> > are skipped.

Hi Dev,

> Some generic comments:
> 1. I think you should also update .gitignore?

I wonder if we could add a checkpatch warning for that, it keeps on 
happening :)

> 2. You can use ksft_exit_fail_perror() for wherever you want to print
> strerror(errno).


Makes sense, thanks!


--
Cheers,

David / dhildenb