Re: [PATCH net v2] fddi: skfp: fix null pointer deferenece in smt.c

[Jakub Kicinski]

On Thu,  8 May 2025 02:07:06 +0530 Siddarth Gundu wrote:
> In smt_string_swap(), when a closing bracket ']' is encountered
> before any opening bracket '[' open_paren would be NULL,
> and assigning it to format would lead to a null pointer being
> dereferenced in the format++ statement.
> 
> Add a check to verify open_paren is non-NULL before assigning
> it to format

You'd have to explain where an invalid format could come from.
As far as I can tell they are all hardcoded (grep for SWAP_SMT)
-- 
pw-bot: cr