Re: [PATCH v2 5/7] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card

[Prasad Kumpatla]

On 4/29/2025 4:28 PM, Konrad Dybcio wrote:
> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
> > From: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> >
> > Add the sound card node with tested playback over WSA8835 speakers
> > and digital on-board mics.
> >
> > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 49 ++++++++++++++++++++
> >   1 file changed, 49 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index 43cbdbe43afd..9cfe648e29bb 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -1078,6 +1078,55 @@
> >   	status = "okay";
> >   };
> >   
> > +&sound {
> > +	compatible = "qcom,qcs6490-rb3gen2-sndcard";
> > +	model = "qcs6490-rb3gen2-snd-card";
> > +
> > +	audio-routing =
> > +		"SpkrLeft IN", "WSA_SPK1 OUT",
>
> Please unbreak the line and align the entries
>
> [...]
Ack>
> > +		"SpkrRight IN", "WSA_SPK2 OUT",
> > +		"VA DMIC0", "vdd-micb",
> > +		"VA DMIC1", "vdd-micb",
> > +		"VA DMIC2", "vdd-micb",
> > +		"VA DMIC3", "vdd-micb";
> > +
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +
> > +	wsa-dai-link {
> > +		link-name = "WSA Playback";
> > +
> > +		codec {
> > +			sound-dai = <&left_spkr>, <&right_spkr>, <&swr2 0>,
> > +					<&lpass_wsa_macro 0>;
>
> Please align the <s
Ack>
> Konrad