Re: [PATCH v2 4/7] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier

[Prasad Kumpatla]

On 4/29/2025 4:27 PM, Konrad Dybcio wrote:
> On 4/29/25 11:24 AM, Prasad Kumpatla wrote:
> > From: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> >
> > Add nodes for WSA8830 speakers amplifier on qcs6490-rb3gen2 board.
> >
> > Enable lpass_wsa and lpass_va macros along with pinctrl settings
> > for audio.
> >
> > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@xxxxxxxxxxx>
> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 70 ++++++++++++++++++++
> >   1 file changed, 70 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > index 5fbcd48f2e2d..43cbdbe43afd 100644
> > --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> > @@ -19,6 +19,7 @@
> >   #include "pm7325.dtsi"
> >   #include "pm8350c.dtsi"
> >   #include "pmk8350.dtsi"
> > +#include "qcs6490-audioreach.dtsi"
> >   
> >   /delete-node/ &ipa_fw_mem;
> >   /delete-node/ &rmtfs_mem;
> > @@ -765,6 +766,44 @@
> >   	};
> >   };
> >   
> > +&lpass_dmic01_clk {
> > +	drive-strength = <8>;
> > +	bias-disable;
> > +};
> > +
> > +&lpass_dmic01_data {
> > +	bias-pull-down;
> > +};
> > +
> > +&lpass_dmic23_clk {
> > +	drive-strength = <8>;
> > +	bias-disable;
> > +};
> > +
> > +&lpass_dmic23_data {
> > +	bias-pull-down;
> > +};
> > +
> > +&lpass_va_macro {
> > +	status = "okay";
> > +};
> > +
> > +&lpass_wsa_macro {
> > +	status = "okay";
> > +};
> > +
> > +&lpass_wsa_swr_clk {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-disable;
> > +};
> > +
> > +&lpass_wsa_swr_data {
> > +	drive-strength = <2>;
> > +	slew-rate = <1>;
> > +	bias-bus-hold;
> > +};
>
> These properties should likely be moved to sc7280.dtsi
Ack>
> > +
> >   &mdss {
> >   	status = "okay";
> >   };
> > @@ -1039,6 +1078,31 @@
> >   	status = "okay";
> >   };
> >   
> > +&swr2 {
> > +	status = "okay";
>
> Please keep a newline between the properties and first subnode
Ack>
> [...]
>
> >   &tlmm {
> >   	gpio-reserved-ranges = <32 2>, /* ADSP */
> >   			       <48 4>; /* NFC */
> > @@ -1095,6 +1159,12 @@
> >   		 */
> >   		bias-pull-up;
> >   	};
> > +
> > +	sw_ctrl: sw-ctrl-state {
>
> Not only non-descript, this node is not used
Will check and update

Thanks,
Prasad>
> Konrad