Re: [PATCH v3 0/5] NMI warning and debug improvements

[Arnaldo Carvalho de Melo]

On Wed, Apr 02, 2025 at 04:33:25PM -0400, Liang, Kan wrote:
> 
> 
> On 2025-04-02 4:15 p.m., Ian Rogers wrote:
> > The NMI warning wouldn't fire even if all the events were for one PMU
> > type. Remove a nearby, and no longer useful, mixed hardware event
> > group function. Improve the evlist to string function and dump it in
> > verbose mode after the reordered events warning.
> > 
> > As commonly happens legacy events like instructions will be uniquified
> > to hybrid events like cpu_core/instructions/, even though the
> > encodings differ. To make this correct either:
> > https://lore.kernel.org/lkml/20250312211623.2495798-1-irogers@xxxxxxxxxx/
> > or:
> > https://lore.kernel.org/linux-perf-users/20250109222109.567031-1-irogers@xxxxxxxxxx/
> > needs merging.
> > 
> > v3: Increase the verbose dump length from 1024 to 2048 as requested by
> >     Kan Liang.
> > 
> > v2: Rename evlist__has_hybrid to evlist__has_hybrid_pmus and add a
> >     max_length parameter to evlist__format_evsels as suggested by Kan
> >     Liang.
> > 
> > Ian Rogers (5):
> >   perf stat: Better hybrid support for the NMI watchdog warning
> >   perf stat: Remove print_mixed_hw_group_error
> >   perf evlist: Refactor evlist__scnprintf_evsels
> >   perf evlist: Add groups to evlist__format_evsels
> >   perf parse-events: Add debug dump of evlist if reordered
> 
> Reviewed-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>

Thanks, applied to perf-tools-next,

- Arnaldo