Re: [PATCH v4 15/31] x86/resctrl: Add and initialize rdt_resource for package scope core monitor

[Reinette Chatre]

Hi Tony,

On 4/28/25 5:33 PM, Tony Luck wrote:
> Counts for each Intel telemetry event are periodically sent to one or
> more aggregators on each package where accumulated totals are made
> available in MMIO registers.
> 
> Add a new resource for monitoring these events with code to build

It is unnecessary to say that code is used to add a change.

> domains at the package granularity.
> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
>  include/linux/resctrl.h            |  2 ++
>  arch/x86/kernel/cpu/resctrl/core.c | 11 +++++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> index 6f424fffa083..3ae50b947a99 100644
> --- a/include/linux/resctrl.h
> +++ b/include/linux/resctrl.h
> @@ -53,6 +53,7 @@ enum resctrl_res_level {
>  	RDT_RESOURCE_L2,
>  	RDT_RESOURCE_MBA,
>  	RDT_RESOURCE_SMBA,
> +	RDT_RESOURCE_PERF_PKG,
>  
>  	/* Must be the last */
>  	RDT_NUM_RESOURCES,
> @@ -250,6 +251,7 @@ enum resctrl_scope {
>  	RESCTRL_L2_CACHE = 2,
>  	RESCTRL_L3_CACHE = 3,
>  	RESCTRL_L3_NODE,
> +	RESCTRL_PACKAGE,
>  };
>  
>  /**
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 2f3efc4b1816..4d1556707c01 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -99,6 +99,15 @@ struct rdt_hw_resource rdt_resources_all[RDT_NUM_RESOURCES] = {
>  			.schema_fmt		= RESCTRL_SCHEMA_RANGE,
>  		},
>  	},
> +	[RDT_RESOURCE_PERF_PKG] =
> +	{
> +		.r_resctrl = {
> +			.rid			= RDT_RESOURCE_PERF_PKG,

https://lore.kernel.org/lkml/20250425173809.5529-20-james.morse@xxxxxxx/

Reinette