Re: [PATCH V2] arm64/debug: Drop redundant DBG_MDSCR_* macros

[Ada Couprie Diaz]

Hi Anshuman,

On 08/05/2025 05:47, Anshuman Khandual wrote:

> MDSCR_EL1 has already been defined in tools sysreg format and hence can be
> used in all debug monitor related call paths. Subsequently all DBG_MDSCR_*
> macros become redundant and hence can be dropped off completely. While here
> convert all variables handling MDSCR_EL1 register as u64 which reflects its
> true width as well.
>
> Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
> Cc: Will Deacon <will@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Cc: linux-kernel@xxxxxxxxxxxxxxx
> Signed-off-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> ---
> This patch applies on v6.15-rc5
>
> Changes in V2:
>
> - Changed reg, val width to u64 in cortex_a76_erratum_1463225_svc_handler() per Ada
> - Changed mdscr register width to uint64_t in enable_monitor_debug_exceptions() and
>    install_ss() per Ada

Thanks for the changes, the patch looks good to me now !

Reviewed-by: Ada Couprie Diaz <ada.coupriediaz@xxxxxxx>