Re: [PATCH v6 3/3] PCI: tegra: Allow building as a module

[Aaron Kling]

On Thu, May 8, 2025 at 3:40 AM Thierry Reding <thierry.reding@xxxxxxxxx> wrote:
>
> On Wed, May 07, 2025 at 10:25:54PM -0500, Aaron Kling via B4 Relay wrote:
> > From: Aaron Kling <webgeek1234@xxxxxxxxx>
> >
> > This changes the module macro back to builtin, which does not define an
> > exit function. This will prevent the module from being unloaded. There
> > are concerns with modules not cleaning up IRQs on unload, thus this
> > needs specifically disallowed. The remove callback is also dropped as it
> > is unused.
>
> What exactly are these concerns? I haven't done this lately, but I'm
> pretty sure that unbinding the PCI controller is something that I
> extensively tested back when this code was introduced. PCI is designed
> to be hot-pluggable, so there shouldn't be a need to prevent unloading
> of the controller.
>
> Rather than just forcing this to be always there, can we not fix any
> issues and keep this unloadable?

For the short version, see this part of the conversation on v1 [0].
For the long version, read comments on all revisions. Basically, I
originally submitted this as unloadable, but got told that due to
generic concerns that affect all pci drivers, including ones already
modules and unloadable, making this one a module would be blocked if
it was unloadable. Which leads us to this revision of the series.

Sincerely,
Aaron

[0] https://lore.kernel.org/all/4u4h27w77sdjvy43b3yonidhfjuvljylms3qxqfaqwyw3v32qo@kzgrrenxr6yz/