Re: [PATCH v4 01/25] media: iris: Skip destroying internal buffer if not dequeued

[Dikshita Agarwal]

On 5/7/2025 8:37 PM, Bryan O'Donoghue wrote:
> On 07/05/2025 08:39, Dikshita Agarwal wrote:
>> Firmware might hold the DPB buffers for reference in case of sequence
>> change, so skip destroying buffers for which QUEUED flag is not removed.
>> Also, make sure that all buffers are released during streamoff.
>>
>> Cc: stable@xxxxxxxxxxxxxxx
>> Fixes: 73702f45db81 ("media: iris: allocate, initialize and queue
>> internal buffers")
>> Reviewed-by: Vikash Garodia <quic_vgarodia@xxxxxxxxxxx>
>> Signed-off-by: Dikshita Agarwal <quic_dikshita@xxxxxxxxxxx>
> 
> I'll take your word for it on firmware respecting the software contract on
> close() wrt to DMA - however I think you should split this patch into two
> separate patches along the lines of the "also" in your commit log.
> 
> 1. Skip destroying buffers for QUEUED flag
> 2. Make sure all buffers are released during stream off
> 
> These are two separate fixes IMO.
Sure will split.

Please let me know if you have any other comments
if no comments, will send v5 with addressing above.

Thanks,
Dikshita
> 
> ---
> bod