Re: [PATCH -v2] accel/habanalabs: Don't build the driver on UML

From: Johannes Berg
Date: Thu May 08 2025 - 05:02:38 EST


On Thu, 2025-05-08 at 10:57 +0200, Ingo Molnar wrote:
> >
> > I dunno. I guess we can put rdtsc() into UML on x86 as I suggested about
> > the file placement, or we can also just fix the Kconfig there.
>
> The Kconfig solution looks much simpler to me too :)
>
> Patch attached, does this look good to you?

Yeah looks good to me. Common gotcha really.

Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

If anyone _really_ needs to have this driver built on UML (say for
simulations/testing, we do build iwlwifi for all the time), then they'd
probably want to replace the rdtsc() anyway with something else there.

johannes