Re: [PATCH v3 5/5] phy: qcom: qmp-pcie: add x1e80100 qref supplies

[Qiang Yu]

On 5/8/2025 4:20 PM, Johan Hovold wrote:
> On Thu, May 08, 2025 at 04:15:14PM +0800, Wenbin Yao wrote:
> > From: Qiang Yu <quic_qianyu@xxxxxxxxxxx>
> >
> > All PCIe PHYs on the X1E80100 SOC require the vdda-qref, which feeds QREF
> > clocks provided by the TCSR device.
> This still looks wrong and you never replied to why these supplies
> shouldn't be handled by the tcsr clock driver that supplies these
> clocks:
>
> 	https://lore.kernel.org/lkml/aBHUmXx6N72_sCH9@xxxxxxxxxxxxxxxxxxxx/
Sorry, I thought Konrad had convinced you.

If the TCSR driver manages these supplies, would it be possible for tscr
driver to recognize when it needs to turn vdda-qref on or off for a
specific PCIe port?
> > Hence, restore the vdda-qref request for the 6th PCIe instance by reverting
> > commit 031b46b4729b ("phy: qcom: qmp-pcie: drop bogus x1e80100 qref
> > supplies"). For the 4th PCIe instance (Gen3 x2), add a new driver data
> > entry, namely x1e80100_qmp_gen3x2_pciephy_cfg, which is a copy of
> > sm8550_qmp_gen3x2_pciephy_cfg but uses sm8550_qmp_phy_vreg_l instead.
> >
> > Fixes: 031b46b4729b ("phy: qcom: qmp-pcie: drop bogus x1e80100 qref supplies")
> > Fixes: 606060ce8fd0 ("phy: qcom-qmp-pcie: Add support for X1E80100 g3x2 and g4x2 PCIE")
> > Cc: Johan Hovold <johan+linaro@xxxxxxxxxx>
> > Cc: Abel Vesa <abel.vesa@xxxxxxxxxx>
> > Signed-off-by: Qiang Yu <quic_qianyu@xxxxxxxxxxx>
> > Signed-off-by: Wenbin Yao <quic_wenbyao@xxxxxxxxxxx>
> Johan

--
With best wishes
Qiang Yu