RE: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support
From: Pankit Garg
Date: Thu May 08 2025 - 01:22:01 EST
> -----Original Message-----
> From: Conor Dooley <conor@xxxxxxxxxx>
> Sent: Wednesday, May 7, 2025 7:53 PM
> To: Pankit Garg <pankit.garg@xxxxxxx>
> Cc: linux-rtc@xxxxxxxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; conor+dt@xxxxxxxxxx; robh@xxxxxxxxxx;
> alexandre.belloni@xxxxxxxxxxx; Vikash Bansal <vikash.bansal@xxxxxxx>;
> Priyanka Jain <priyanka.jain@xxxxxxx>; Daniel Aguirre
> <daniel.aguirre@xxxxxxx>; Shashank Rebbapragada
> <shashank.rebbapragada@xxxxxxx>; Aman Kumar Pandey
> <aman.kumarpandey@xxxxxxx>
> Subject: [EXT] Re: [PATCH v3 1/2] dt-bindings: rtc: Add pcf85053a support
>
> On Wed, May 07, 2025 at 12:56:17PM +0530, Pankit Garg wrote:
> > Add device tree bindings for NXP PCF85053a RTC chip.
> >
> > Signed-off-by: Pankit Garg <pankit.garg@xxxxxxx>
> > ---
> > V2 -> V3: Moved MAINTAINERS file changes to the driver patch
> > V1 -> V2: Handled dt-bindings by trivial-rtc.yaml
>
> You forgot to add my ack.
> Acked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
Yes, I forgot. I will add it in v4. Let me wait for more review/comments for couple of days.
>
> >
> > ---
> > Documentation/devicetree/bindings/rtc/trivial-rtc.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > index 7330a7200831..47be7bbbfedd 100644
> > --- a/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > +++ b/Documentation/devicetree/bindings/rtc/trivial-rtc.yaml
> > @@ -65,6 +65,8 @@ properties:
> > - microcrystal,rv8523
> > # NXP LPC32xx SoC Real-time Clock
> > - nxp,lpc3220-rtc
> > + # NXP PCF85053A Real Time Clock Module with I2C-Bus
> > + - nxp,pcf85053a
> > # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> > - ricoh,r2025sd
> > # I2C bus SERIAL INTERFACE REAL-TIME CLOCK IC
> > --
> > 2.25.1
> >