Re: [PATCH] dt-bindings: display/msm: hdmi: Fix constraints on additional 'port' properties

From: Dmitry Baryshkov
Date: Thu May 08 2025 - 00:03:38 EST


On Wed, May 07, 2025 at 04:59:12PM -0500, Rob Herring (Arm) wrote:
> The MSM HDMI port nodes are missing any restrictions on additional
> properties. The $ref should be to "/properties/port" rather than
> "/$defs/port-base" as there are not additional properties in the nodes
> to define.
>
> Signed-off-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/display/msm/hdmi.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>

I've verified, it applies on top of msm-next and produces no errors. I
don't see a meaningful error in the bot's message (Rob, is there a
chance to fix the bot?).

>
> diff --git a/Documentation/devicetree/bindings/display/msm/hdmi.yaml b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> index d4a2033afea8..099274d35680 100644
> --- a/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/hdmi.yaml
> @@ -89,12 +89,12 @@ properties:
> $ref: /schemas/graph.yaml#/properties/ports
> properties:
> port@0:
> - $ref: /schemas/graph.yaml#/$defs/port-base
> + $ref: /schemas/graph.yaml#/properties/port
> description: |
> Input endpoints of the controller.
>
> port@1:
> - $ref: /schemas/graph.yaml#/$defs/port-base
> + $ref: /schemas/graph.yaml#/properties/port
> description: |
> Output endpoints of the controller.
>
> --
> 2.47.2
>

--
With best wishes
Dmitry