Re: [PATCH v4 1/8] dt-bindings: serial: describe SA8255p
From: Krzysztof Kozlowski
Date: Mon May 05 2025 - 05:59:56 EST
On 05/05/2025 08:51, Praveen Talari wrote:
>>>>> + serial@990000 {
>>>>> + compatible = "qcom,sa8255p-geni-uart";
>>>>> + reg = <0x990000 0x4000>;
>>>>> + interrupts = <GIC_SPI 531 IRQ_TYPE_LEVEL_HIGH>;
>>>> Why isn't here wakeup interrupt? Commit msg also does not help me to
>>>> understand why number of interrupts varies.
>>> Currently we are not using wake-irq because it is optional for our current
>>> implementation.
>> Great explanation. I asked why is it optional, answer because it is
>> optional.
> sorry.
>>
>> What does it mean optional? This is part of the SoC, so how given one,
>> fixed SoC can have it routed or not routed in the same time?
>
> the serial driver doesn't enter runtime suspend mode until the port is
> closed.
>
> therefore, there is no need for a wake IRQ when the driver is in an
> active state
You described current Linux driver, so if we change Linux driver or we
try for example FreeBSD, then bindings are different?
Again, explain how SoC can have this interrupt not routed.
Best regards,
Krzysztof