Re: [PATCH v1 1/1] list: Remove redundant 'extern' for function prototypes

[Andy Shevchenko]

Sat, May 03, 2025 at 07:35:42PM -0700, Andrew Morton kirjoitti:
> On Fri,  2 May 2025 15:17:42 +0300 Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> 
> > The 'extern' keyword is redundant for function prototypes.
> > list.h never used them and new code in general is better
> > without them.

...

> > -extern bool __list_valid_slowpath __list_del_entry_valid_or_report(struct list_head *entry);
> > +bool __list_valid_slowpath __list_del_entry_valid_or_report(struct list_head *entry);
> 
> I'll apply this because you continue to do significant work on list.h
> but I don't want to spend the next 5 years buried in little "remove
> externs" patches!

Thank you!

FWIW, I made this change because (as stated in the commit message) list.h from
the beginning hasn't used that keyword and a relatively new change brought
this. It's not a part of any huge churn, and just a standalone ad-hoc change.


-- 
With Best Regards,
Andy Shevchenko