Re: [PATCH v4 1/2] rust: samples: add missing newline to pr_info! calls in rust_print_main

From: Miguel Ojeda
Date: Sun May 04 2025 - 15:49:05 EST


On Sun, May 4, 2025 at 5:41 PM Alban Kurti via B4 Relay
<devnull+kurti.invicto.ai@xxxxxxxxxx> wrote:
>
> From: Alban Kurti <kurti@xxxxxxxxxx>
>
> Fixes: f431c5c581fa ("samples: rust: print: Add sample code for Arc printing")
> Reported-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1139
> Signed-off-by: Alban Kurti <kurti@xxxxxxxxxx>

Commit messages cannot be empty, even if they may be apparently
trivial -- could you please describe the changes a bit? (i.e. "what"
and "why").

Also, I think you sent two patches with the exact same title -- I
think you did it because the Fixes tag is different, which is good.
However, you could mention the difference in the title and message?
For instance:

rust: samples: rust_print_main: add missing newline in basic pr_info! calls
rust: samples: rust_print_main: add missing newline in Arc<dyn>
pr_info! call

Thanks for sending these fixes!

Cheers,
Miguel