Re: [PATCH v2 3/5] iio: adc: ad7606: add offset and phase calibration support

[Jonathan Cameron]

On Fri, 02 May 2025 15:27:00 +0200
Angelo Dureghello <adureghello@xxxxxxxxxxxx> wrote:

> From: Angelo Dureghello <adureghello@xxxxxxxxxxxx>
> 
> Add support for offset and phase calibration, only for
> devices that support software mode, that are:
> 
> ad7606b
> ad7606c-16
> ad7606c-18
> 
> Signed-off-by: Angelo Dureghello <adureghello@xxxxxxxxxxxx>

One trivial typo.

> +static int ad7606_set_calib_phase(struct ad7606_state *st, int ch, int val,
> +				  int val2)
> +{
> +	int wreg, start_ns, step_ns, stop_ns;
> +
> +	if (val != 0)
> +		return -EINVAL;
> +
> +	start_ns = st->chip_info->calib_phase_avail[0][1];
> +	step_ns = st->chip_info->calib_phase_avail[1][1];
> +	stop_ns = st->chip_info->calib_phase_avail[2][1];
> +
> +	/*
> +	 * ad7606b: phase dielay from 0 to 318.75 μs in steps of 1.25 μs.

Spell check. delay



> +	 * ad7606c-16/18: phase delay from 0 µs to 255 µs in steps of 1 µs.
> +	 */