Re: [PATCH 0/7] arm64: dts: qcom: x1e80100-*: Drop useless DP3 compatible override

[Dmitry Baryshkov]

On Wed, Apr 30, 2025 at 12:39:13PM +0300, Abel Vesa wrote:
> On 25-04-30 01:26:13, Sebastian Reichel wrote:
> > Hi,
> > 
> > On Tue, Apr 29, 2025 at 10:42:28AM +0300, Abel Vesa wrote:
> > > It all started with the support for CRD back when we had different
> > > compatibles for eDP and DP. Meanwhile, that has been sorted out and it
> > > is now figured out at runtime while using only the DP compatible.
> > > 
> > > It's almost funny how this got copied over from CRD and spread to all
> > > X Elite platforms.
> > > 
> > > TBH, the best reason to drop it ASAP is to make sure this doesn't spread
> > > beyond X Elite to newer platforms.
> > > 
> > > Functionally nothing changes.
> > 
> > Looking at the diff I wonder if this part should also be simplified:
> > 
> > /delete-property/ #sound-dai-cells;
> > 
> > This is done by all upstream X1E boards, so maybe just drop the
> > #sound-dai-cells directly in x1e80100.dtsi?
> 
> Yeah, I'm not sure about that.
> 
> Though the DP3 PHY is currently used as eDP, I think it could be used
> as DP. So I think it makes more sense to keep the DP3 controller as is
> in the SoC dtsi and delete the #sound-dai-cells property in each board
> specific dts. Don't know if it will ever be the case with this SoC, but
> maybe someone will use DP3 with the PHY configured as DP rather than
> eDP.
> 
> Not sure if I'm 100% right about this though.
> 
> Dmitry, Bjorn, do you think that is accurate enough?

Yes, this sounds logical. DP3 is repurposed for eDP on a board level, so
the SoC configuration should not contain any specific config for that
port.

> 
> > 
> > Greetings,
> > 
> > -- Sebastian
> 
> 

-- 
With best wishes
Dmitry