Re: [PATCH net-next v2] selftests: iou-zcrx: Clean up build warnings for error format

[David Wei]

On 5/2/25 10:50, Haiyue Wang wrote:
> Clean up two build warnings:
>
> [1]
>
> iou-zcrx.c: In function ‘process_recvzc’:
> iou-zcrx.c:263:37: warning: too many arguments for format [-Wformat-extra-args]
>    263 |                         error(1, 0, "payload mismatch at ", i);
>        |                                     ^~~~~~~~~~~~~~~~~~~~~~
>
> [2] Use "%zd" for ssize_t type as better
>
> iou-zcrx.c: In function ‘run_client’:
> iou-zcrx.c:357:47: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘ssize_t’ {aka ‘long int’} [-Wformat=]
>    357 |                         error(1, 0, "send(): %d", sent);
>        |                                              ~^   ~~~~
>        |                                               |   |
>        |                                               int ssize_t {aka long int}
>        |                                              %ld
>
> Signed-off-by: Haiyue Wang <haiyuewa@xxxxxxx>

> ---
> v2:
>    - Dont't wrap the build warning message to make scripts/checkpatch.pl happy,
>      keep it as for readability.
>    - Change the format for ssize_t from "%ld" to "%zd" as Simon suggested.
>    - Change the target to net-next tree.
> v1: https://lore.kernel.org/netdev/20250502042240.17371-1-haiyuewa@xxxxxxx/

Thanks for the cleanups. But next time please note that there is a 24h
cooldown on respins in netdev.

Reviewed-by: David Wei <dw@xxxxxxxxxxx>