Re: [PATCH v8 06/43] arm64: RME: Define the user ABI

[Suzuki K Poulose]

On 01/05/2025 14:31, Steven Price wrote:
> On 28/04/2025 09:58, Suzuki K Poulose wrote:
> > Hi Steven
> >
> > On 16/04/2025 14:41, Steven Price wrote:
> > > There is one (multiplexed) CAP which can be used to create, populate and
> > > then activate the realm.
> > >
> > > Co-developed-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> > > Signed-off-by: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> > > Signed-off-by: Steven Price <steven.price@xxxxxxx>
> > > ---
> > > Changes since v7:
> > >    * Add documentation of new ioctls
> > >    * Bump the magic numbers to avoid conflicts
> > > Changes since v6:
> > >    * Rename some of the symbols to make their usage clearer and avoid
> > >      repetition.
> > > Changes from v5:
> > >    * Actually expose the new VCPU capability (KVM_ARM_VCPU_REC) by bumping
> > >      KVM_VCPU_MAX_FEATURES - note this also exposes KVM_ARM_VCPU_HAS_EL2!
> > > ---
> > >    Documentation/virt/kvm/api.rst    | 70 +++++++++++++++++++++++++++++++

> > May be rephrase it to:
> >
> > No changes can be made to Realm's memory (including the IPA state). No
> > new VCPUs can be created after this step.
>
> I was attmepting to include that CONFIG_REALM cannot be called. How about:
>
> 	Request the RMM to activate the realm. No
> 	changes can be made to the Realm's memory,
> 	IPA state or configuration parameters.  No
> 	new VCPUs can be created after this step.

Looks good to me, cheers

Suzuki