RE: [Patch v2 2/4] uio_hv_generic: Use correct size for interrupt and monitor pages

From: Michael Kelley
Date: Wed Apr 30 2025 - 21:56:09 EST


From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx> Sent: Wednesday, April 30, 2025 3:06 PM
>
> Interrupt and monitor pages should be in Hyper-V page size (4k bytes).
> This can be different to the system page size.

s/different to/different from/

>
> This size is read and used by the user-mode program to determine the
> mapped data region. An example of such user-mode program is the VMBUS

s/VMBUS/VMBus/

> driver in DPDK.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 95096f2fbd10 ("uio-hv-generic: new userspace i/o driver for VMBus")
> Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>
> ---
> drivers/uio/uio_hv_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
> index 1b19b5647495..08385b04c4ab 100644
> --- a/drivers/uio/uio_hv_generic.c
> +++ b/drivers/uio/uio_hv_generic.c
> @@ -287,13 +287,13 @@ hv_uio_probe(struct hv_device *dev,
> pdata->info.mem[INT_PAGE_MAP].name = "int_page";
> pdata->info.mem[INT_PAGE_MAP].addr
> = (uintptr_t)vmbus_connection.int_page;
> - pdata->info.mem[INT_PAGE_MAP].size = PAGE_SIZE;
> + pdata->info.mem[INT_PAGE_MAP].size = HV_HYP_PAGE_SIZE;
> pdata->info.mem[INT_PAGE_MAP].memtype = UIO_MEM_LOGICAL;
>
> pdata->info.mem[MON_PAGE_MAP].name = "monitor_page";
> pdata->info.mem[MON_PAGE_MAP].addr
> = (uintptr_t)vmbus_connection.monitor_pages[1];
> - pdata->info.mem[MON_PAGE_MAP].size = PAGE_SIZE;
> + pdata->info.mem[MON_PAGE_MAP].size = HV_HYP_PAGE_SIZE;
> pdata->info.mem[MON_PAGE_MAP].memtype = UIO_MEM_LOGICAL;
>
> if (channel->device_id == HV_NIC) {
> --
> 2.34.1
>