Re: [PATCH 2/2] kunit: add tips to clean source tree to build help message

[Shuah Khan]

On 4/29/25 23:18, Mauro Carvalho Chehab wrote:
> Em Tue, 29 Apr 2025 16:27:12 -0600
> Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> escreveu:
>
> > Add tips to clean source tree to build help message. When user run
> > kunit.py after building another kernel for ARCH=foo, it is necessary
> > to run 'make ARCH=foo mrproper' to remove all build artifacts generated
> > during the build. In such cases, kunit build could fail.
> >
> > Signed-off-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> > ---
> >   tools/testing/kunit/kunit.py | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
> > index 7f9ae55fd6d5..db86a396ed33 100755
> > --- a/tools/testing/kunit/kunit.py
> > +++ b/tools/testing/kunit/kunit.py
> > @@ -583,7 +583,7 @@ def main(argv: Sequence[str]) -> None:
> >   						'the options in .kunitconfig')
> >   	add_common_opts(config_parser)
> >   
> > -	build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests')
> > +	build_parser = subparser.add_parser('build', help='Builds a kernel with KUnit tests. Successful build depends on a clean source tree. Run mrproper to clean generated artifcats for prior ARCH=foo kernel build. Run 'make ARCH=foo mrproper')
> >   	add_common_opts(build_parser)
> >   	add_build_opts(build_parser)
> >   
> Would be better instead to detect if the last build was not done
> by kunit.py and call "make mrproper" inside kunit.py?

Detecting last build and printing out the right "make ARCH= mrproper"
command is good. I don't think we want run the call make mrproper from
kunit.py - this shouldn't be a automatic step. It would be annoying
to loose build artifacts if it isn't what user would want.

thanks,
-- Shuah

> Thanks,
> Mauro