Re: [PATCH v5 0/3] Add USB2PHY Port Reset Control driver for Renesas RZ/V2H(P) SoC
From: Lad, Prabhakar
Date: Wed Apr 30 2025 - 16:37:48 EST
Hi Philipp,
On Tue, Apr 15, 2025 at 8:51 PM Prabhakar <prabhakar.csengg@xxxxxxxxx> wrote:
>
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Hi All,
>
> This patch series adds support for the USB2PHY Port Reset control driver
> for the Renesas RZ/V2H(P) SoC. The changes include documenting the USB2PHY
> Port Reset control bindings and adding the driver.
>
> v4->v5
> - Added Reviewed-by tag from Biju Das for patch 2/3
> - Dropped NULL check for of_device_get_match_data() in probe()
> - Dropped dev_set_drvdata() in probe()
>
> v3->v4
> - Added Reviewed-by tag from Krzysztof Kozlowski for patch 1/3
> - Updated commit message for patch 1/3 as per review comments
>
> v2->v3
> - Dropped Acks from Conor and Fabrizio, due to below changes
> - Renamed binding renesas,rzv2h-usb2phy-ctrl.yaml to
> renesas,rzv2h-usb2phy-reset.yaml
> - Renamed node name in example to reset-controller
> - Renamed function names in reset-rzv2h-usb2phy.c
> - Kept the reset line in asserted state during probe
> - Added comment for rzv2h_init_vals[]
> - Added entry in MAINTAINERS file
>
> v1->v2
> - Dropped binding postfix in subject line for patch 1/2
> - Moved acquiring the ctrl2 pin in deassert callback
> - Updated ctrl_status_bits
>
> Cheers,
> Prabhakar
>
> Lad Prabhakar (3):
> dt-bindings: reset: Document RZ/V2H(P) USB2PHY reset
> reset: Add USB2PHY port reset driver for Renesas RZ/V2H(P)
> MAINTAINERS: Add entry for Renesas RZ/V2H(P) USB2PHY Port Reset driver
>
> .../reset/renesas,rzv2h-usb2phy-reset.yaml | 56 +++++
> MAINTAINERS | 8 +
> drivers/reset/Kconfig | 7 +
> drivers/reset/Makefile | 1 +
> drivers/reset/reset-rzv2h-usb2phy.c | 236 ++++++++++++++++++
> 5 files changed, 308 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/renesas,rzv2h-usb2phy-reset.yaml
> create mode 100644 drivers/reset/reset-rzv2h-usb2phy.c
>
Gentle ping for review.
Cheers,
Prabhakar