Re: [PATCH v1 12/19] ACPICA: Introduce ACPI_NONSTRING

From: Rafael J. Wysocki
Date: Wed Apr 30 2025 - 14:50:03 EST


On Wed, Apr 30, 2025 at 8:35 PM Kees Cook <kees@xxxxxxxxxx> wrote:
>
> On Fri, Apr 25, 2025 at 09:27:58PM +0200, Rafael J. Wysocki wrote:
> > From: Kees Cook <kees@xxxxxxxxxx>
> >
> > ACPICA commit 878823ca20f1987cba0c9d4c1056be0d117ea4fe
> >
> > In order to distinguish character arrays from C Strings (i.e. strings with
> > a terminating NUL character), add support for the "nonstring" attribute
> > provided by GCC. (A better name might be "ACPI_NONCSTRING", but that's
> > the attribute name, so stick to the existing naming convention.)
> >
> > GCC 15's -Wunterminated-string-initialization will warn about truncation
> > of the NUL byte for string initializers unless the destination is marked
> > with "nonstring". Prepare for applying this attribute to the project.
> >
> > Link: https://github.com/acpica/acpica/commit/878823ca
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
>
> Whoops, I missed adding my S-o-b to the original upstream ACPICA commit.
> Please consider this:
>
> Signed-off-by: Kees Cook <kees@xxxxxxxxxx>

Added, thanks!