Re: [PATCH] pinctrl: tigerlake: Document supported platforms in Kconfig help

[Andy Shevchenko]

On Wed, Apr 30, 2025 at 6:32 PM Ariel Simulevski <ariel@xxxxxxxxxxxxx> wrote:

Technically this is a v2 of the previous patch, but it has been
changed a lot, so for _this_ time it's okay to have it still v1. Also
note when v2 or any new version of patch is required the changelog
must be provided (after the cutter '---' line below).

> The Tiger Lake pinctrl driver is also used by some Alder Lake platforms
> that reuse the same GPIO IP blocks.
>
> Update the Kconfig help texts for both drivers to document supported
> platforms

> and clarify when CONFIG_PINCTRL_TIGERLAKE may be required.

This should be done in the same way....

> Supported platforms:
>   - Tiger Lake (all variants)

Have you checked this (that's all versions of Tiger Lake are in this driver)?

>   - Alder Lake-P

> +         Some platforms may reuse GPIO IP blocks from earlier generations
> +         and require CONFIG_PINCTRL_TIGERLAKE instead.

Just list the supported platforms:
- Alder Lake-N
- Alder Lake-S

And I believe some of Raptor Lake:s are also require this driver.

> +         Also used on some Alder Lake platforms that share compatible GPIO IP.

No need to have this text, it's obvious from the below list.

> +         Supported platforms:
> +           - Tiger Lake (all variants)
> +           - Alder Lake-P

...

With that, waiting for v2.

-- 
With Best Regards,
Andy Shevchenko