Re: [PATCH 01/13] crypto: sha256 - support arch-optimized lib and expose through shash
From: Eric Biggers
Date: Sat Apr 26 2025 - 21:50:53 EST
On Sun, Apr 27, 2025 at 09:17:28AM +0800, Herbert Xu wrote:
> On Sat, Apr 26, 2025 at 06:12:28PM -0700, Eric Biggers wrote:
> >
> > No, that would be silly. I'm not doing that. The full update including the
> > partial block handling is already needed in the library. There is no need to
> > implement it again at the shash level.
>
> shash implements a lot more algorithms than the lib/crypto interface.
> If you won't do this then I'll just do it instead.
But this one does have a lib/crypto/ interface now. There's no reason not to
use it here.
- Eric