Re: [PATCH v6 3/3] iio: dac: ad3530r: Add driver for AD3530R and AD3531R

[Jonathan Cameron]

On Fri, 25 Apr 2025 11:48:50 -0500
David Lechner <dlechner@xxxxxxxxxxxx> wrote:

> On 4/25/25 7:54 AM, Kim Seer Paller wrote:
> > The AD3530/AD3530R (8-channel) and AD3531/AD3531R (4-channel) are
> > low-power, 16-bit, buffered voltage output DACs with software-
> > programmable gain controls, providing full-scale output spans of 2.5V or
> > 5V for reference voltages of 2.5V. These devices operate from a single
> > 2.7V to 5.5V supply and are guaranteed monotonic by design. The "R"
> > variants include a 2.5V, 5ppm/°C internal reference, which is disabled
> > by default.
> > 
> > Support for monitoring internal die temperature, output voltages, and
> > current of a selected channel via the MUXOUT pin using an external ADC
> > is currently not implemented.
> > 
> > Signed-off-by: Kim Seer Paller <kimseer.paller@xxxxxxxxxx>
> > ---  
> 
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> 
> Just a few small things in the latest changes that could be improved...

FWIW I took another look and have nothing to add to David's review comments.

Hopefully with those tweaks v7 should be good to go.

Thanks,

Jonathan