Re: [PATCH net-next v12 1/9] netmem: add niov->type attribute to distinguish different net_iov types

[Christophe JAILLET]

Hi,

below a few nitpicks in case of a v13.


Le 25/04/2025 à 22:47, Mina Almasry a écrit :
> Later patches in the series adds TX net_iovs where there is no pp
> associated, so we can't rely on niov->pp->mp_ops to tell what is the
> type of the net_iov.
>
> Add a type enum to the net_iov which tells us the net_iov type.
>
> Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
>
> ---

Nitpick: unneeded empty need line above ---?

...

> +enum net_iov_type {
> +	NET_IOV_DMABUF,
> +	NET_IOV_IOURING,
> +
> +	/* Force size to unsigned long to make the NET_IOV_ASSERTS below pass.
> +	 */
> +	NET_IOV_MAX = ULONG_MAX,

Nitpick: unneeded trailing , after such a terminator.

> +};

...

CJ